elastic / elasticsearch-specification

Elasticsearch full specification
Apache License 2.0
111 stars 67 forks source link

Base types should not be never #2612

Closed Anaethelion closed 4 weeks ago

Anaethelion commented 4 weeks ago

types.ts in output wrongly flags empty Base types as [key:string]: never while they should really be {}.

github-actions[bot] commented 4 weeks ago

The backport to 8.13 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.13 8.13
# Navigate to the new working tree
cd .worktrees/backport-8.13
# Create a new branch
git switch --create backport-2612-to-8.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 289be00fed14456d30512e35b60f17857bcfd93c
# Push it to GitHub
git push --set-upstream origin backport-2612-to-8.13
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.13

Then, create a pull request where the base branch is 8.13 and the compare/head branch is backport-2612-to-8.13.