Open pgayvallet opened 1 week ago
I think this type follows the same semantics as RangeQuery
which means that it should accept arbitrary typed values for the from
and to
fields.
The corresponding RangeAggregate
looks suspicious to me as well. We should double check the server code here as well.
🐛 Wrong type
AggregationRange.from
andAggregationRange.to
were changed fromstring | number
tonumber
in https://github.com/elastic/elasticsearch-specification/pull/2552From the PR:
This was supposed to be done to address https://github.com/elastic/elasticsearch-java/issues/666, but the assumption that was used for the PR is wrong, For
RangeAggrations
at least,from
andto
do supportstring
type value, for patterns such asnow
ornow+X
.E.g from the Kibana repo:
https://github.com/elastic/kibana/blob/1c1e20afdb883fc279c5a06d4b71f8e577f8dad6/x-pack/plugins/task_manager/server/monitoring/workload_statistics.ts#L169-L180