elastic / elasticsearch-specification

Elasticsearch full specification
Apache License 2.0
121 stars 70 forks source link

Add missing type for ignore_dynamic_beyond_limit for the Indices Settings API #2653

Closed achyutjhunjhunwala closed 3 months ago

achyutjhunjhunwala commented 3 months ago

Summary

The Index Settings API returns an additional optional field called ignore_dynamic_beyond_limit. The Type definition for the same was missing in the specifications. Hence as part of this PR added.

Full API details from the edge-lite server

Request

GET /logs-endpoint.alerts-default/_settings

Response

{
  ".ds-logs-endpoint.alerts-default-2024.06.24-000001": {
    "settings": {
      "index": {
        "mapping": {
          "nested_fields": {
            "limit": "80"
          },
          "total_fields": {
            "limit": "5000",
            "ignore_dynamic_beyond_limit": "true"
          },
          "ignore_malformed": "true"
        },
        "hidden": "true",
        "provided_name": ".ds-logs-endpoint.alerts-default-2024.06.24-000001",
        "final_pipeline": ".fleet_final_pipeline-1",
        "creation_date": "1719193327497",
        "number_of_replicas": "1",
        "uuid": "GnzWPltpSHKtwnyC3QdH2Q",
        "version": {
          "created": "8508000"
        },
        "lifecycle": {
          "name": "logs"
        },
        "codec": "best_compression",
        "routing": {
          "allocation": {
            "include": {
              "_tier_preference": "data_hot"
            }
          }
        },
        "number_of_shards": "1",
        "default_pipeline": "logs-endpoint.alerts-8.14.0"
      }
    }
  }
}
github-actions[bot] commented 3 months ago

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.add_block :green_circle: 2/2 2/2
indices.analyze :green_circle: 20/20 20/20
indices.clear_cache :green_circle: 4/4 4/4
indices.clone :green_circle: 5/5 5/5
indices.close :green_circle: 49/49 49/49
indices.create_data_stream :green_circle: 28/28 28/28
indices.create :red_circle: 908/945 945/945
indices.data_streams_stats :green_circle: 4/4 4/4
indices.delete_alias :red_circle: 15/15 5/15
indices.delete_data_lifecycle :white_circle: Missing test Missing test
indices.delete_data_stream :green_circle: 28/28 28/28
indices.delete_index_template :green_circle: 1/1 1/1
indices.delete_template :green_circle: 9/9 9/9
indices.delete :green_circle: 105/105 105/105
indices.disk_usage :green_circle: 5/5 5/5
indices.downsample :green_circle: 1/1 1/1
indices.exists_alias :green_circle: 36/36 36/36
indices.exists_index_template :white_circle: Missing test Missing test
indices.exists_template :green_circle: 15/15 15/15
indices.exists :green_circle: 39/39 39/39
indices.explain_data_lifecycle :white_circle: Missing test Missing test
indices.field_usage_stats :green_circle: 5/5 5/5
indices.flush :green_circle: 30/30 30/30
indices.forcemerge :red_circle: 12/12 11/12
indices.get_alias :red_circle: 83/83 71/83
indices.get_data_lifecycle :white_circle: Missing test Missing test
indices.get_data_stream :red_circle: 12/12 3/12
indices.get_field_mapping :red_circle: 15/15 14/15
indices.get_index_template :red_circle: 19/19 15/19
indices.get_mapping :red_circle: 120/120 108/120
indices.get_settings :red_circle: 61/61 59/61
indices.get_template :green_circle: 30/30 30/30
indices.get :green_circle: 53/53 53/53
indices.migrate_to_data_stream :white_circle: Missing test Missing test
indices.modify_data_stream :white_circle: Missing test Missing test
indices.open :green_circle: 18/18 18/18
indices.promote_data_stream :white_circle: Missing test Missing test
indices.put_alias :red_circle: 59/59 20/59
indices.put_data_lifecycle :white_circle: Missing test Missing test
indices.put_index_template :red_circle: 50/52 52/52
indices.put_mapping :red_circle: 75/103 103/103
indices.put_settings :red_circle: 54/57 57/57
indices.put_template :red_circle: 44/49 49/49
indices.recovery :green_circle: 9/9 9/9
indices.refresh :green_circle: 264/264 264/264
indices.reload_search_analyzers :green_circle: 2/2 2/2
indices.resolve_cluster :red_circle: 10/12 12/12
indices.resolve_index :green_circle: 6/6 6/6
indices.rollover :red_circle: 26/26 1/26
indices.segments :red_circle: 6/6 5/6
indices.shard_stores :red_circle: 5/5 4/5
indices.shrink :green_circle: 5/5 5/5
indices.simulate_index_template :red_circle: 6/7 5/7
indices.simulate_template :red_circle: 5/5 4/5
indices.split :green_circle: 11/11 11/11
indices.stats :red_circle: 103/103 31/102
indices.unfreeze :green_circle: 1/1 1/1
indices.update_aliases :red_circle: 26/26 7/26
indices.validate_query :green_circle: 7/7 7/7

You can validate these APIs yourself by using the make validate target.

github-actions[bot] commented 3 months ago

The backport to 8.13 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.13 8.13
# Navigate to the new working tree
cd .worktrees/backport-8.13
# Create a new branch
git switch --create backport-2653-to-8.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 084db754215a47db52b5c288629a21f1737c9081
# Push it to GitHub
git push --set-upstream origin backport-2653-to-8.13
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.13

Then, create a pull request where the base branch is 8.13 and the compare/head branch is backport-2653-to-8.13.

github-actions[bot] commented 3 months ago

The backport to 8.14 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.14 8.14
# Navigate to the new working tree
cd .worktrees/backport-8.14
# Create a new branch
git switch --create backport-2653-to-8.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 084db754215a47db52b5c288629a21f1737c9081
# Push it to GitHub
git push --set-upstream origin backport-2653-to-8.14
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.14

Then, create a pull request where the base branch is 8.14 and the compare/head branch is backport-2653-to-8.14.