search

elastic / elasticsearch-specification

Elasticsearch full specification
Apache License 2.0
121 stars 70 forks source link

Merge `query_rule` and `query_ruleset` namespaces into `query_rules` #2656

Closed kderusso closed 3 months ago

kderusso commented 3 months ago

Moves the query_rule and query_ruleset namespaces into a single top level query_rules namespace.

Followup to https://github.com/elastic/elasticsearch-specification/pull/2639

github-actions[bot] commented 3 months ago

Following you can find the validation results for the APIs you have changed.

API Status Request Response
query_rules.query_rule_delete :white_circle: Missing test Missing test
query_rules.query_rule_get :white_circle: Missing test Missing test
query_rules.query_rule_put :white_circle: Missing test Missing test
query_rules.query_ruleset_delete :white_circle: Missing test Missing test
query_rules.query_ruleset_get :white_circle: Missing test Missing test
query_rules.query_ruleset_list :white_circle: Missing test Missing test
query_rules.query_ruleset_put :white_circle: Missing test Missing test

You can validate these APIs yourself by using the make validate target.

kderusso commented 3 months ago

What are your thoughts around using those names instead?

client.query_rules.get_ruleset(...) client.query_rules.get_rule(...)

😅 Yeah, those are cleaner, I'll update both PRs today.

github-actions[bot] commented 3 months ago

Following you can find the validation results for the APIs you have changed.

API Status Request Response
query_rules.delete_rule :white_circle: Missing test Missing test
query_rules.delete_ruleset :white_circle: Missing test Missing test
query_rules.get_rule :white_circle: Missing test Missing test
query_rules.get_ruleset :white_circle: Missing test Missing test
query_rules.list_rulesets :white_circle: Missing test Missing test
query_rules.put_rule :white_circle: Missing test Missing test
query_rules.put_ruleset :white_circle: Missing test Missing test

You can validate these APIs yourself by using the make validate target.

github-actions[bot] commented 3 months ago

Following you can find the validation results for the APIs you have changed.

API Status Request Response
query_rules.delete_rule :white_circle: Missing test Missing test
query_rules.delete_ruleset :white_circle: Missing test Missing test
query_rules.get_rule :white_circle: Missing test Missing test
query_rules.get_ruleset :white_circle: Missing test Missing test
query_rules.list_rulesets :white_circle: Missing test Missing test
query_rules.put_rule :white_circle: Missing test Missing test
query_rules.put_ruleset :white_circle: Missing test Missing test

You can validate these APIs yourself by using the make validate target.