search

elastic / elasticsearch-specification

Elasticsearch full specification
Apache License 2.0
110 stars 66 forks source link

Validate generation more extensively #2662

Closed pquentin closed 5 days ago

pquentin commented 5 days ago

I believe https://github.com/elastic/elasticsearch-specification/pull/2548 broke OpenAPI generation: https://github.com/elastic/elasticsearch-specification/actions/runs/9712341316/job/26806908311, which prevented the "Generate output" step to run.

Adding all necessary steps in make contrib and running them during PR validation will help notice those issues before merging.

pquentin commented 5 days ago

https://github.com/elastic/elasticsearch-specification/actions/runs/9739075639/job/26873669785?pr=2662 is failing as expected. We can merge this when the build is fixed, in this pull request or another one.