Add two new config options to the DSN editor

elastic / elasticsearch-sql-odbc

ODBC driver for Elasticsearch SQL

Other

0 stars 30 forks source link

Add two new config options to the DSN editor #237

Closed bpintea closed 4 years ago

bpintea commented 4 years ago

This PR adds two new options to the configuration editor:

a numerical one, for the varchar limitation;
a boolean/tick one, for the early execution.

Some of the existing texts for the checkboxes have been updated to have the question marks removed.

Fixes #234.

codebrain commented 4 years ago

LGTM, the only thing is that it might be worth revisiting the documentation page here: https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-odbc-setup.html with the additional parameters?

bpintea commented 4 years ago

LGTM, the only thing is that it might be worth revisiting the documentation page here: https://www.elastic.co/guide/en/elasticsearch/reference/current/sql-odbc-setup.html with the additional parameters?

Thanks, I've opened https://github.com/elastic/elasticsearch/pull/54632.