search

elastic / elasticsearch

Free and Open, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
69.44k stars 24.57k forks source link

Add tests to ensure consistent behaviour / semantics between local and ccs searches #100184

Open piergm opened 11 months ago

piergm commented 11 months ago

Description

Focus particularly on async-search.

IDEA: build another test like CCSDuelIT (except I would make it an IT test, not a qa test, so pattern it after CCSDuelIT in testing pattern, but use CrossClusterAsyncSearchIT as the guide for how to implement/structure the test). This “duel” would be between async local-only and async CCS tests. Test every response object (such as is_partial, which motivated this test) to make sure they are either the same between the two or legitmately different. (Example of legimately different: there is no _cluster/details section for local-only searches.).

The goal is to prevent future changes from letting local-only and cross-cluster searches unintentinally diverge in behavior.

elasticsearchmachine commented 11 months ago

Pinging @elastic/es-search (Team:Search)

elasticsearchmachine commented 1 month ago

Pinging @elastic/es-search-foundations (Team:Search Foundations)