search

elastic / elasticsearch

Free and Open, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
69.53k stars 24.61k forks source link

DFS phase does not support search timeout #104186

Open javanna opened 8 months ago

javanna commented 8 months ago

Search timeout support is currently only available in the query phase. DFS phase used to be lighter before the introduction of knn, but it should support search timeouts when knn query is being rewritten / executed. Currently, the DFS phase does not set the timeout to the index searcher.

SearchTimeoutIT needs to be expanded to cover for the DFS phase / knn queries. A new unit test similar to QueryPhaseTimeoutTests should be added for the DFS phase, which specifically verifies that the timeout is applied to the knn query rewrite, as well as to the search itself.

elasticsearchmachine commented 8 months ago

Pinging @elastic/es-search (Team:Search)

elasticsearchmachine commented 2 months ago

Pinging @elastic/es-search-foundations (Team:Search Foundations)