elastic / elasticsearch

Free and Open, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
68.68k stars 24.38k forks source link

ESQL QL Grand Refactor #106679

Open nik9000 opened 3 months ago

nik9000 commented 3 months ago

Description

When we built ESQL we built it on top of QL's core, which itself was refactored fairly quickly out of SQL. It's what we had time for and it had a lot of goodies. But it brought a lot of baggage. SQL and EQL live on top of _search and ESQL doesn't, for example.

elasticsearchmachine commented 3 months ago

Pinging @elastic/es-analytical-engine (Team:Analytics)

nik9000 commented 3 months ago
  • Double-check exception management (ie. make sure that all the exceptions thrown are EsqlClientException, and not only QlClientException)

The rest of Elasticsearch doesn't really use special exceptions for a project. I think it'd be worth seeing if we should standardize on the assortment of exceptions the rest of Elasticsearch uses. Not sure we'd actually do it, but worth checking.