Open nik9000 opened 3 months ago
Pinging @elastic/es-analytical-engine (Team:Analytics)
- Double-check exception management (ie. make sure that all the exceptions thrown are
EsqlClientException
, and not onlyQlClientException
)
The rest of Elasticsearch doesn't really use special exceptions for a project. I think it'd be worth seeing if we should standardize on the assortment of exceptions the rest of Elasticsearch uses. Not sure we'd actually do it, but worth checking.
Description
When we built ESQL we built it on top of QL's core, which itself was refactored fairly quickly out of SQL. It's what we had time for and it had a lot of goodies. But it brought a lot of baggage. SQL and EQL live on top of _search and ESQL doesn't, for example.
Expression
treeDataTypes
andEsqlDataTypes
)TypeResolutions
andEsqlTypeResolutions
)EvalMapper
with calls toEvaluatorMapper#toEvaluator
ExpressionTranslators
EvaluatorMapper
to ESQL'sExpression
superclassEsqlClientException
, and not onlyQlClientException
)