search

elastic / elasticsearch

Free and Open, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
69.38k stars 24.55k forks source link

[ML] Inference api cohere rerank unused fields #108260

Open jonathan-buttner opened 4 months ago

jonathan-buttner commented 4 months ago

Description

The cohere rerank implementation allows configuring fields that probably don't apply. The implementation leverages the common settings here: https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/cohere/rerank/CohereRerankServiceSettings.java#L30

Those settings provide the ability to configure things like similarity measure and dimensions which are not applicable to reranking. The common service settings class should be renamed to remove confusion and the rerank service settings probably shouldn't rely on it and only parse the url field.

elasticsearchmachine commented 4 months ago

Pinging @elastic/ml-core (Team:ML)

jasonroy7dct commented 2 months ago

Hi Jonathan,

Is this issue still need to be solved?