elastic / elasticsearch

Free and Open, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
68.62k stars 24.37k forks source link

ESQL: Add abstract test cases for aggregation functions #109917

Open ivancea opened 3 weeks ago

ivancea commented 3 weeks ago

Scalar functions have the AbstractFunctionTestCase, which adds a ton of automatic testing to them. Aggregation functions currently have none. They just have some tests for the Aggregators themselves, but they aren't very "complete", and they don't cover the function as a whole (So an aggregator could not be being called at all).

We should have a similar test coverage for aggregators as we have for scalars.

elasticsearchmachine commented 3 weeks ago

Pinging @elastic/es-analytical-engine (Team:Analytics)