search

elastic / elasticsearch

Free and Open, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
69.41k stars 24.56k forks source link

[CI] LangPainlessClientYamlTestSuiteIT test {yaml=painless/146_dense_vector_bit_basic/Cosine Similarity is not supported} failing #110290

Closed elasticsearchmachine closed 2 months ago

elasticsearchmachine commented 2 months ago

Build Scans:

Reproduction Line:

./gradlew ':modules:lang-painless:yamlRestTest' --tests "org.elasticsearch.painless.LangPainlessClientYamlTestSuiteIT.test {yaml=painless/146_dense_vector_bit_basic/Cosine Similarity is not supported}" -Dtests.seed=ED89F8CD62B783B9 -Dtests.locale=es-ES -Dtests.timezone=America/Lower_Princes -Druntime.java=22

Applicable branches: main

Reproduces locally?: N/A

Failure History: See dashboard&_a=(controlGroupInput:(chainingSystem:HIERARCHICAL,controlStyle:twoLine,ignoreParentSettings:(ignoreFilters:!f,ignoreQuery:!f,ignoreTimerange:!f,ignoreValidations:!t),panels:('0c0c9cb8-ccd2-45c6-9b13-96bac4abc542':(explicitInput:(dataViewId:fbbdc689-be23-4b3d-8057-aa402e9ed0c5,enhancements:(),fieldName:task.keyword,grow:!t,id:'0c0c9cb8-ccd2-45c6-9b13-96bac4abc542',searchTechnique:wildcard,selectedOptions:!(),singleSelect:!t,title:'Gradle%20Task',width:medium),grow:!t,order:0,type:optionsListControl,width:small),'144933da-5c1b-4257-a969-7f43455a7901':(explicitInput:(dataViewId:fbbdc689-be23-4b3d-8057-aa402e9ed0c5,enhancements:(),fieldName:name.keyword,grow:!t,id:'144933da-5c1b-4257-a969-7f43455a7901',searchTechnique:wildcard,selectedOptions:!('test%20%7Byaml%3Dpainless%2F146_dense_vector_bit_basic%2FCosine%20Similarity%20is%20not%20supported%7D'),title:Test,width:medium),grow:!t,order:2,type:optionsListControl,width:medium),'4e6ad9d6-6fdc-4fcc-bf1a-aa6ca79e0850':(explicitInput:(dataViewId:fbbdc689-be23-4b3d-8057-aa402e9ed0c5,enhancements:(),fieldName:className.keyword,grow:!t,id:'4e6ad9d6-6fdc-4fcc-bf1a-aa6ca79e0850',searchTechnique:wildcard,selectedOptions:!('org.elasticsearch.painless.LangPainlessClientYamlTestSuiteIT'),title:Suite,width:medium),grow:!t,order:1,type:optionsListControl,width:medium)))))

Failure Message:

java.lang.AssertionError: Failure at [painless/146_dense_vector_bit_basic:136]: expected [400] status code but api [search] returned [200 OK] [{"took":2,"timed_out":false,"_shards":{"total":2,"successful":1,"skipped":0,"failed":1,"failures":[{"shard":0,"index":"test-index","node":"3RCBJqISShqsIk6rXEn1DA","reason":{"type":"script_exception","reason":"runtime error","script_stack":["org.elasticsearch.server@8.15.0-SNAPSHOT/org.elasticsearch.script.field.vectors.BitBinaryDenseVector.cosineSimilarity(BitBinaryDenseVector.java:71)","org.elasticsearch.server@8.15.0-SNAPSHOT/org.elasticsearch.script.VectorScoreScriptUtils$ByteCosineSimilarity.cosineSimilarity(VectorScoreScriptUtils.java:385)","org.elasticsearch.server@8.15.0-SNAPSHOT/org.elasticsearch.script.VectorScoreScriptUtils$CosineSimilarity.cosineSimilarity(VectorScoreScriptUtils.java:428)","cosineSimilarity(params.query_vector, 'vector')","                       ^---- HERE"],"script":"cosineSimilarity(params.query_vector, 'vector')","lang":"painless","position":{"offset":23,"start":0,"end":47},"caused_by":{"type":"unsupported_operation_exception","reason":"cosineSimilarity is not supported for bit vectors."}}}]},"hits":{"total":0,"max_score":null,"hits":[]}}]

Issue Reasons:

Note: This issue was created using new, in-development muting automation. Please mind any issues.

elasticsearchmachine commented 2 months ago

This has been muted on branch main

Mute Reasons:

Build Scans:

elasticsearchmachine commented 2 months ago

Pinging @elastic/es-core-infra (Team:Core/Infra)

ldematte commented 2 months ago

@benwtrent could this be related to https://github.com/elastic/elasticsearch/pull/110059?

elasticsearchmachine commented 2 months ago

Pinging @elastic/es-search (Team:Search)

mayya-sharipova commented 2 months ago

This happens in cases where an index has more than 1 shards, even if we get expected failures on 1 shard, no failures on other empty shards make the whole request return 200.

I will fix the test to ensure that index has always 1 shard.