search

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
69.91k stars 24.73k forks source link

[CI] ClientYamlTestSuiteIT class failing #114013

Closed elasticsearchmachine closed 2 weeks ago

elasticsearchmachine commented 2 weeks ago

Build Scans:

Reproduction Line:

undefined

Applicable branches: main

Reproduces locally?: N/A

Failure History: See dashboard&_a=(controlGroupInput:(chainingSystem:HIERARCHICAL,controlStyle:twoLine,ignoreParentSettings:(ignoreFilters:!f,ignoreQuery:!f,ignoreTimerange:!f,ignoreValidations:!t),panels:('0c0c9cb8-ccd2-45c6-9b13-96bac4abc542':(explicitInput:(dataViewId:fbbdc689-be23-4b3d-8057-aa402e9ed0c5,enhancements:(),fieldName:task.keyword,grow:!t,id:'0c0c9cb8-ccd2-45c6-9b13-96bac4abc542',searchTechnique:wildcard,selectedOptions:!(),singleSelect:!t,title:'Gradle%20Task',width:medium),grow:!t,order:0,type:optionsListControl,width:small),'144933da-5c1b-4257-a969-7f43455a7901':(explicitInput:(dataViewId:fbbdc689-be23-4b3d-8057-aa402e9ed0c5,enhancements:(),fieldName:name.keyword,grow:!t,id:'144933da-5c1b-4257-a969-7f43455a7901',searchTechnique:wildcard,selectedOptions:!('org.elasticsearch.test.rest.ClientYamlTestSuiteIT'),title:Test,width:medium),grow:!t,order:2,type:optionsListControl,width:medium),'4e6ad9d6-6fdc-4fcc-bf1a-aa6ca79e0850':(explicitInput:(dataViewId:fbbdc689-be23-4b3d-8057-aa402e9ed0c5,enhancements:(),fieldName:className.keyword,grow:!t,id:'4e6ad9d6-6fdc-4fcc-bf1a-aa6ca79e0850',searchTechnique:wildcard,selectedOptions:!('org.elasticsearch.test.rest.ClientYamlTestSuiteIT'),title:Suite,width:medium),grow:!t,order:1,type:optionsListControl,width:medium)))))

Failure Message:

undefined

Issue Reasons:

Note: This issue was created using new test triage automation. Please report issues or feedback to es-delivery.

elasticsearchmachine commented 2 weeks ago

This has been muted on branch main

Mute Reasons:

Build Scans:

elasticsearchmachine commented 2 weeks ago

Pinging @elastic/es-storage-engine (Team:StorageEngine)

kkrik-es commented 2 weeks ago

Not sure why the full test suite got muted.. The bar should be very high for doing so, as this may let regressions slip in - we don't have that luxury with the high cadence of serverless releases.

Brian, can you please take a look? It'd be better to mute 100 individual tests than the full suite.

martijnvg commented 2 weeks ago

It looks like there are mixed causes why the ClientYamlTestSuiteIT failed.

However one linked build in the issue description stands out, because test suites failed because of an assertion error that hasn't been merged yet: https://gradle-enterprise.elastic.co/s/xxoe5shuqhsku/console-log?page=20#L19035 (https://github.com/elastic/elasticsearch/pull/113978/files#diff-5d1b70d8d2fb56b602c4d09a2590185fa79789cf7e8a5fe1bf3e51df3dc83ae2R117) I think PR build failures shouldn't drive opening test failures and muting of tests?

dnhatn commented 2 weeks ago 
[2024-10-03T05:16:02,693][ERROR][o.e.b.Elasticsearch      ] [test-cluster-0] fatal exception while booting Elasticsearch
java.lang.ExceptionInInitializerError: null
    at org.elasticsearch.datastreams.DataStreamsPlugin.getRestHandlers(DataStreamsPlugin.java:254) ~[?:?]
    at org.elasticsearch.datastreams.DataStreamsPlugin.getRestHandlers(DataStreamsPlugin.java:86) ~[?:?]
    at org.elasticsearch.action.ActionModule.initRestHandlers(ActionModule.java:1014) ~[elasticsearch-9.0.0.jar:?]
    at org.elasticsearch.node.NodeConstruction.postInjection(NodeConstruction.java:1407) ~[elasticsearch-9.0.0.jar:?]
    at org.elasticsearch.node.NodeConstruction.construct(NodeConstruction.java:1209) ~[elasticsearch-9.0.0.jar:?]
    at org.elasticsearch.node.NodeConstruction.prepareConstruction(NodeConstruction.java:282) ~[elasticsearch-9.0.0.jar:?]
    at org.elasticsearch.node.Node.<init>(Node.java:200) ~[elasticsearch-9.0.0.jar:?]
    at org.elasticsearch.bootstrap.Elasticsearch$2.<init>(Elasticsearch.java:240) ~[elasticsearch-9.0.0.jar:?]
    at org.elasticsearch.bootstrap.Elasticsearch.initPhase3(Elasticsearch.java:240) ~[elasticsearch-9.0.0.jar:?]
    at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:75) ~[elasticsearch-9.0.0.jar:?]
Caused by: java.lang.IllegalArgumentException: duplicate element: name
    at java.util.ImmutableCollections$SetN.<init>(ImmutableCollections.java:925) ~[?:?]
    at java.util.Set.of(Set.java:637) ~[?:?]
    at org.elasticsearch.datastreams.rest.RestGetDataStreamsAction.<clinit>(RestGetDataStreamsAction.java:36) ~[?:?]
    ... 10 more
lkts commented 2 weeks ago

I don't think failures from pull-request jobs should impact muting of tests (if i read this correctly)?

dnhatn commented 2 weeks ago

This is the from a release test.

dnhatn commented 2 weeks ago

We can include name twice in Set.of(): https://github.com/elastic/elasticsearch/blob/6d7ae82180fa30ee4b48bd58721cae2cda809b15/modules/data-streams/src/main/java/org/elasticsearch/datastreams/rest/RestGetDataStreamsAction.java#L33-L48

dnhatn commented 2 weeks ago

@DaveCTurner I think it was introduced in #113953. Can you take a look?

DaveCTurner commented 2 weeks ago

Darnit, I thought that'd just deduplicate the value. Fix in progress...

DaveCTurner commented 2 weeks ago

Ok I reverted the offending commit, and this test mute.

martijnvg commented 2 weeks ago

Thanks @DaveCTurner for addressing the test mute and @dnhatn for finding the issue!