Expand custom IndexInput testing to cover Lucene's BaseDirectoryTestCase

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine

https://www.elastic.co/products/elasticsearch

Other

69.97k stars 24.75k forks source link

Expand custom IndexInput testing to cover Lucene's BaseDirectoryTestCase #115646

Open ChrisHegarty opened 3 hours ago

ChrisHegarty commented 3 hours ago

Custom IndexInput implementations in Elasticsearch should be tested by Lucene's BaseDirectoryTestCase. The BaseDirectoryTestCase exercises many baseline scenarios that any implementation should adhere to.

This issue has been filed when we identified a bug in the BlobCacheBufferedIndexInput (#115594), which would likely have been caught if testing used BaseDirectoryTestCase.

elasticsearchmachine commented 3 hours ago

Pinging @elastic/es-search (Team:Search)