Closed ivancea closed 3 days ago
Pinging @elastic/es-analytical-engine (Team:Analytics)
@alex-spies In CombineProjections
we aren't using the return value (Until the Categorize PR), so all nice! Thanks for checking!
If tests are ok (And in the other PR, they were), we should be fine then :blob:
Thanks for yanking it into it's own PR!
Also updated the QL counterpart. I didn't find any usage of the add(), at all
Status | Branch | Result |
---|---|---|
✅ | 8.x |
Set/Collection#add() is supposed to return
true
if the collection changed (If it actually added something). In this case, it must return if the old value is null.Extracted from https://github.com/elastic/elasticsearch/pull/114317 (Where it's being used)