Deprecate and remove distance_type parameter from geo_distance query DSL

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine

https://www.elastic.co/products/elasticsearch

Other

1.1k stars 24.83k forks source link

Deprecate and remove distance_type parameter from geo_distance query DSL #22914

Open nknize opened 7 years ago

nknize commented 7 years ago

This is a follow up to #19846 for deprecating (5.x) and removing (6.0) the distance_type parameter from the geo_distance query dsl. The idea is to provide a single implementation that is consistent with how Lucene's LatLonPoint computes distances.

colings86 commented 7 years ago

@nknize I made this and adoptme as it seems like something that we intend to do

imotov commented 5 years ago

Marking as team-discuss since we need to come up with new set of version numbers here since depreciation PRs didn't make it to the versions that we originally anticipated.

polyfractal commented 5 years ago

Discussed in A&G meeting, we're going to bump the deprecation to 7.0+ and remove fully in 8.0. It's not a huge burden to maintain, and at this point the deprecation warning in 6.6+ wouldn't give users enough time to migrate.

We'll find some owners for the existing PRs and get them moving again.

djptek commented 3 years ago

@iverase is _geo_distance supposed to be supported as a nested sort at this stage (geo_point not geo_shape)? I have a related failing test in https://github.com/elastic/elasticsearch/pull/39425 on that one & I have doubts whether the intention was to implement that functionality here

elasticsearchmachine commented 4 months ago

Pinging @elastic/es-analytical-engine (Team:Analytics)