search

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
1.15k stars 24.84k forks source link

HasChildQueryBuilderTests failing since recent commit #29362

Closed jasontedor closed 6 years ago

jasontedor commented 6 years ago

These tests are failing, I think because of 569d0c0e897478be4f05a1daba8d217a526e0eeb. At least, it smells like the right commit, and git bisect got me there too:

23:11:19 3d [jason@totoro:~/src/elastic/elasticsearch] 8cdd950056+ ± git bisect good
569d0c0e897478be4f05a1daba8d217a526e0eeb is the first bad commit
commit 569d0c0e897478be4f05a1daba8d217a526e0eeb
Author: Adrien Grand <jpountz@gmail.com>
Date:   Tue Apr 3 16:45:25 2018 +0200

    Improve similarity integration. (#29187)

    This improves the way similarities are plugged in in order to:
     - reject the classic similarity on 7.x indices and emit a deprecation
       warning otherwise
     - reject unkwown parameters on 7.x indices and emit a deprecation
       warning otherwise

    Even though this breaks the plugin API, I'd like to backport to 7.x so
    that users can get deprecation warnings when they are doing something
    that will become unsupported in the future.

    Closes #23208
    Closes #29035

:040000 040000 cdc2dfb96c77d7a088cc58efce355db6c22b7377 65f47af116ffa3d8e12a7c13c3690dad0bf9d9da M  docs
:040000 040000 ad69b9119d00655673aae59b72139d986bd00ab1 d2b66fc88e60296e54240a080704fc0964424d7f M  modules
:040000 040000 482430ff202254db09e9422ceb29eb075868d5ee d5cd5ea179b52a79948ed0f3b7e5953f7a8eaabe M  server
:040000 040000 0d672b64f3eab521e74360d00848b70a669dcb47 5e965416e51ec86466ca7989780916a81b03d52f M  test

Here's a reproducing line:

./gradlew :modules:parent-join:test -Dtests.seed=4016CC723BC06B1 -Dtests.class=org.elasticsearch.join.query.HasChildQueryBuilderTests -Dtests.security.manager=true -Dtests.locale=mk -Dtests.timezone=Africa/Niamey

This gives:

> Task :modules:parent-join:test FAILED
Tests with failures:
  - org.elasticsearch.join.query.HasChildQueryBuilderTests.testToQuery
  - org.elasticsearch.join.query.HasChildQueryBuilderTests.testFromXContent
  - org.elasticsearch.join.query.HasChildQueryBuilderTests.testNonDefaultSimilarity
elasticmachine commented 6 years ago

Pinging @elastic/es-search-aggs

jasontedor commented 6 years ago

I pushed 4b1ed20a67375da62927e811fe44f491045ecd7e.

jasontedor commented 6 years ago

To be clear, the above commit is to mark the test as needing a fix.