Setting index.warmer.enabled is undocumented

elastic / elasticsearch

Free and Open, Distributed, RESTful Search Engine

https://www.elastic.co/products/elasticsearch

Other

69.49k stars 24.6k forks source link

Open DaveCTurner opened 6 years ago

DaveCTurner commented 6 years ago

The documentation for the index.warmer.enabled setting was lost in f123a53d7258349a171e47a35f4581899d8fa776. It was almost entirely a link to the documentation about index warmers that no longer exists: https://github.com/elastic/elasticsearch/blob/1df2d3015efee3e3d0df0696729c4e509363a5af/docs/reference/indices/update-settings.asciidoc#L155

elasticmachine commented 6 years ago

Pinging @elastic/es-search-aggs

jrodewig commented 5 years ago

Hi @DaveCTurner

There also appear to be no links to indices-warmers in the current documentation.

Are you comfortable with me closing this ticket?

DaveCTurner commented 5 years ago

Hi @jrodewig, the index.warmer.enabled setting still exists in master:

Although it does much less than what it used to in the 2.x series it still does something. I think we should either document it or remove it.

jimczi commented 5 years ago

We discussed this issue internally and decided that we should remove this setting. Today it is used for two things:

To load the global ordinals if eager_global_ordinals is set on the field.
To load the bitset filters for all nested fields present in the mapping. The former can be controlled on a per field basis while the latter can be controlled with another setting called index.load_fixed_bitset_filters_eagerly so there's no need to keep index.warmer.enabled at all.

elasticsearchmachine commented 1 year ago

Pinging @elastic/es-search (Team:Search)

elasticsearchmachine commented 1 month ago

Pinging @elastic/es-search-foundations (Team:Search Foundations)