SQL: Upgrade H2 to 1.4.198

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine

https://www.elastic.co/products/elasticsearch

Other

1.17k stars 24.84k forks source link

SQL: Upgrade H2 to 1.4.198 #39895

Open costin opened 5 years ago

costin commented 5 years ago

H2 had a new release in February 2019 with a long changelog - besides a lot of bugfixes, it introduced support for Geometry (still based on JTS) and INTERVALs. We should upgrade the jar but also, if possible, update our tests from CSV to SQL on the interval front.

elasticmachine commented 5 years ago

Pinging @elastic/es-search

costin commented 3 years ago

The latest version at the moment is 1.4.200

Luegg commented 3 years ago

I had look at upgrading H2 and this is what I found:

H2 1.4.200 introduces a bug that triggers an AccessControlException when using a java security policy (https://github.com/h2database/h2database/issues/2397). A fix has already been merged and will be available with the next H2 release. 1.4.199 does not have this issue.
H2Gis 1.5.0 does not work with H2 1.4.199. According to https://stackoverflow.com/questions/60541794/spring-boot-app-with-embedded-h2gis-initialization-throws-sql-syntax-error each H2GIS version only works with one specific H2 version (1.4.197 in this case).

So it looks like we're stuck with 1.4.197 until a new version of H2GIS is released.

Luegg commented 3 years ago

For future reference, https://github.com/elastic/elasticsearch/pull/75173 documents the necessary changes to make the non-GIS related tests work with 1.4.199.

costin commented 3 years ago

Thanks @Luegg . Let's revisit this when the next release of H2 will show up - based on #75173 we already have a cost associated with the upgrade, let's see whether there's an upside to it (INTERVAL support).

elasticsearchmachine commented 2 years ago

Pinging @elastic/es-ql (Team:QL)

elasticsearchmachine commented 10 months ago

Pinging @elastic/es-analytical-engine (Team:Analytics)