SQL: Types class refactoring

elastic / elasticsearch

Free and Open, Distributed, RESTful Search Engine

https://www.elastic.co/products/elasticsearch

Other

69.42k stars 24.57k forks source link

SQL: Types class refactoring #51482

Open astefan opened 4 years ago

astefan commented 4 years ago

At the moment org.elasticsearch.xpack.sql.type.Types has code exclusively used in tests for testing JSON mappings' validity. The way a json containing an index mapping is loaded and interpreted, though, differs from the main code of ES SQL (residing in IndexResolver) and the algorithms are significantly different. This means that, whenever the code in IndexResolver changes (for example - https://github.com/elastic/elasticsearch/pull/51251), the code in Types needs to change as well which introduces an unnecessary maintenance task.

elasticmachine commented 4 years ago

Pinging @elastic/es-search (:Search/SQL)

soarescaique commented 3 years ago

Can I work on this?

matriv commented 3 years ago

Hi @soarescaique Thank you for your interest in contributing! Inline with common open source practices, we would like to no longer block and attribute issues, but rather invite anyone with a concrete proposal to simply submit a PR. No one likes duplicating work, but please consider that chances of concurrent PRs are low - especially for longer standing issues - and quality will trump over submission order.

elasticsearchmachine commented 7 months ago

Pinging @elastic/es-analytical-engine (Team:Analytics)