SQL: improve scripting constants and formatting

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine

https://www.elastic.co/products/elasticsearch

Other

69.98k stars 24.75k forks source link

SQL: improve scripting constants and formatting #54095

Open costin opened 4 years ago

costin commented 4 years ago

Currently, with the tests and some of the code generation, we end up doing a lot of string manipulation which is hard to refactor. A couple of improvements would help:

replace constants like {ql} or {InternalSqlScriptUtilswith references toScripts` constants
find a better way to format then the verbose format(Locale.ROOT, "%s") pattern. We cannot use LogMessageFormatter since {} are internally but maybe an auxiliary method would help.

elasticmachine commented 4 years ago

Pinging @elastic/es-search (:Search/SQL)

elasticsearchmachine commented 9 months ago

Pinging @elastic/es-analytical-engine (Team:Analytics)