search

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
69.61k stars 24.64k forks source link

SQL: fix escaping in TSV. Remove "header" URL attribute for CSV format #60271

Open bpintea opened 4 years ago

bpintea commented 4 years ago

The TSV format doesn't currently properly escape the \ character; a value of \t can thus not be correctly returned. The \r character should also be escaped.

The CSV format queries and acts on a header URL attribute, but this is currently neither supported, nor documented or properly tested (though it is misleadingly used in testing). Alternatively, we could consider adding this as a feature, in line with what other RDBMs are doing (Postgresql, SSRS etc). (This could potentially also allow for a more unequivocal naming of the hasHeader method deciding in fact if the response should contain the columns' headers.)

elasticmachine commented 4 years ago

Pinging @elastic/es-ql (:Query Languages/SQL)

elasticsearchmachine commented 8 months ago

Pinging @elastic/es-analytical-engine (Team:Analytics)