elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
69.74k stars 24.68k forks source link

Replace group settings with affix settings #68143

Open williamrandolph opened 3 years ago

williamrandolph commented 3 years ago

The core-infra team would like to remove group settings from our code, but there are remaining places where group settings must be replaced with affix settings first. It's possible that in some cases group settings are providing functionality that's not available with affix settings; if so, we ought to know about it so that we can try to provide that functionality with affix settings.

Replacing group settings with affix settings often requires additional definition of the settings in question, so the actual work of the conversion should be handled by the team that owns the setting, with core/infra providing help and advice if needed.

Usages of GroupSettings in main code

Notification services

These classes all use the same pattern, where group settings are nested within an affix setting definition

Tests of groupSettings

These are tests of setting functionality and shouldn't be removed unless all usages of GroupSettings are removed.

elasticmachine commented 3 years ago

Pinging @elastic/es-core-infra (Team:Core/Infra)