elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
69.94k stars 24.74k forks source link

Be stricter about partial downloads in repository analyser #75109

Open DaveCTurner opened 3 years ago

DaveCTurner commented 3 years ago

Today the repository analyser uses the BlobContainer#readBlob methods to read data from the repository. The implementations of these methods are typically resilient to various failures such as a connection dropped mid-download, and will silently resume a failed download when it makes sense to do so. Such problems should be rare in practice; a repository that consistently fails mid-download will appear to work correctly but with reduced resilience and performance.

The repository analyser should avoid silently retrying on failures and should instead consider them as an analysis failure.

elasticmachine commented 3 years ago

Pinging @elastic/es-distributed (Team:Distributed)