search

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
1.51k stars 24.9k forks source link

geo bounds aggregation: Add support for geo_shape. #7574

Closed yeroc closed 4 years ago

yeroc commented 10 years ago

Some time ago I created an enhancement request to support a bounding box aggregation (#5634) as this is very useful for mapping applications to allow a map to zoom to the extent (bounding box) of all matches. This was implemented in v1.3.0 but unfortunately only for the geo_point type.

clintongormley commented 10 years ago

@colings86 what do you think?

emmanuelmathot commented 10 years ago

I would find this feature very useful as well. We would generate density maps from those aggregation!

yeroc commented 9 years ago

Any update on this? Does this require some additional features in Lucene or does this require changes to ElasticSearch only?

nknize commented 9 years ago

No additional Lucene features required to support this feature. I'm currently refactoring some legacy geo_point code to reuse geo_shape logic that fixes polygonal ambiguity issues. Once that's done adding support for this request will be relatively straight-forward.

yeroc commented 9 years ago

@nknize Thanks a lot for the update.

emmanuelmathot commented 9 years ago

Great

emmanuelmathot commented 9 years ago

Any planned date for release?

clintongormley commented 9 years ago

@nknize just assigned this to you so you don't miss it

clintongormley commented 9 years ago

@nknize just pinging for an update on this.

carlosvega commented 9 years ago

+1

nknize commented 9 years ago

2.2 for sure and can be back ported to 2.0+ (@clintongormley thoughts on back porting?).

clintongormley commented 9 years ago

@nknize new features/enhancements go into the current stable branch and above only (ie 2.2+ at the moment)

samchorlton commented 8 years ago

What is the latest on this?

nknize commented 8 years ago

This was put on hold to prioritize spatial indexing performance issues in lucene 6.0. Once we get that stable this will move back up in the list.

samchorlton commented 8 years ago

Ok cool thanks for letting me know. Do you know if this will add support to allow aggregation of geoshape polygons or is this just for aggregation of points by polygons?

nknize commented 8 years ago

Yes, its to provide geo_bounds support for geo_shape field types. So geo_shape fields will be aggregated into a single bounding box.

yeroc commented 8 years ago

@nknize I see the Lucene 6.1 release notes mention improvements to spatial indexing so assume the work you mention in your previous notes has been completed. Does this mean this ticket is on deck now or is there still more work to be done prior? Thanks!

ghost commented 8 years ago

+1

howlowck commented 8 years ago

How are we doing on this feature?

aparnavarma92 commented 8 years ago

+1 this would be very useful functionality

yeroc commented 7 years ago

@nknize Do you have an update on this?

hanoch commented 7 years ago

👍

rtrujill007 commented 7 years ago

👍 @nknize @sherry-ger Any updates on this issue?

emmanuelmathot commented 7 years ago

Is there any technical difficulty hard to solve for this issue?

stevewillard commented 7 years ago

What ever happened with this issue? Is there a branch where the work for this was started?

hanoch commented 7 years ago

@sherry-ger @nknize - any updates on this issue?

clintongormley commented 7 years ago

We won't be working on this until BKD-backed geoshapes are merged

hanoch commented 7 years ago

@clintongormley when is the "BKD-backed geoshapes" planned to be merged?

clintongormley commented 7 years ago

@hanoch when it is ready. I can't be any more specific than that

bilalvdemir commented 6 years ago

Hi, this feature has complate? @clintongormley

BrianDMay commented 6 years ago

+1

abuddenb commented 6 years ago

+1

hanoch commented 6 years ago

any progress on that?

refaelasraf commented 6 years ago

Have any updates on that ?

hanoch commented 6 years ago

@nknize is this now addressed with the ES 6.5.0 release and https://github.com/elastic/elasticsearch/pull/32730 PR merge?

imotov commented 5 years ago

@hanoch no, we still need get #32039 in first

nknize commented 5 years ago

We also won't be able to add geo_shape aggregations until we come up w/ a reasonable doc value representation for geo_shape. WKB seems the best option at the moment but we need to investigate docValue size limits in lucene.

It is possible that we will need to limit the number of shape vertices to comply w/ Lucene docValue size limits for geo_shape fields that have docValues enabled. /brainstorm /cc @jpountz

imotov commented 5 years ago

Depends on #37206

babadofar commented 5 years ago

Apparently Kibana believes this has been fixed already. See this bug report https://github.com/elastic/kibana/issues/31589

thomasneirynck commented 5 years ago

This is a requirement to be able to do layer-fitting on layers backed by geo_shape fields in the maps app. cf. https://github.com/elastic/kibana/issues/33509

hanoch commented 5 years ago

Any progress on this issue? any ETA?

talevy commented 5 years ago

@hanoch there is some progress. there is a feature branch that this issue is tracking: https://github.com/elastic/elasticsearch/issues/37206.

The feature branch has partial support for aggregations for now, one being geo_bounds: https://github.com/elastic/elasticsearch/pull/45413

Unfortunately, I cannot share an ETA for this work, but I can say that it is actively being worked on!

talevy commented 4 years ago

this was implemented in https://github.com/elastic/elasticsearch/pull/55328!