search

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
1.28k stars 24.86k forks source link

YAML tests skipped unless using (nonexistent) OSS distribution #78977

Open DaveCTurner opened 3 years ago

DaveCTurner commented 3 years ago

Today the YAML test framework has features xpack and no_xpack to skip certain tests depending on whether they're using the OSS distribution or not.

https://github.com/elastic/elasticsearch/blob/2d6f8d1e0cd1ef313e8a65825c2156e4e8b39b07/rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/README.asciidoc#L175-L179

However today there is no OSS distribution, so xpack is a no-op and no_xpack is an unconditional skip. We should fix up (or remove) any tests that are marked as no_xpack and then drop this functionality.

elasticmachine commented 3 years ago

Pinging @elastic/es-delivery (Team:Delivery)

mark-vieira commented 3 years ago

We still have the integTest distribution though which doesn't include x-pack by default. Although I'm wondering why there would be YAML tests which rely on x-pack in a non-xpack module to begin with?