elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
1.21k stars 24.84k forks source link

License service metadata updates don't respect `?master_timeout` #85996

Open DaveCTurner opened 2 years ago

DaveCTurner commented 2 years ago

There are various cluster state updates in LicenseService triggered by MasterNodeRequest derivatives. MasterNodeRequest#masterNodeTimeout usually defines the timeout for cluster state update tasks, and this field is mostly populated correctly at the REST layer but it is not passed to the master service so these tasks never time out and will sit in the pending task queue until eventually processed. That can be confusing to clients which hit a client-side timeout before the task completes, since these clients may see their requests taking effect hours (days?) later even after receiving an error response.

elasticmachine commented 2 years ago

Pinging @elastic/es-security (Team:Security)