Open rjernst opened 2 years ago
Pinging @elastic/es-core-infra (Team:Core/Infra)
@rjernst do we still plan to keep some (most?) of these as immutable maps, or are we converting to mutable HashMap
-like maps for these?
Yes I think they can and should remain immutable, just immutable Map instances with Map.of or Map.copyOf.
ImmutableOpenMap
was added to the cluster/index metadata classes in #86673 for performance reasons. So we need to find a different collection type (maybe guava immutablemap?) if we want to remove ImmutableOpenMap
https://github.com/elastic/elasticsearch/pull/90006 caused a performance drop, needs to be thought about more
After https://github.com/elastic/elasticsearch/issues/84735, hppc usage in Elasticsearch is now isolated to
ImmutableOpenMap
andImmutableOpenIntMap
. This is a meta issue delineating the remaining uses of those classes that need to be removed.