search

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
69.79k stars 24.69k forks source link

APM module startTrace method doesn't create spans #90833

Open DJRickyB opened 1 year ago

DJRickyB commented 1 year ago

When implementing #90574, I added a second startTrace method that uses the active context to link a new span to a parent. In testing, this method invocation was required to create activation events required for inferred span, but they didn't actually create instrumented spans of their own.

Based on this code: https://github.com/elastic/elasticsearch/blob/73cdc7b80ab42c5335512d86eb09b1ac1a085f85/server/src/main/java/org/elasticsearch/search/SearchService.java#L627-L642

...I would have expected to see a blue span below that was just called executeQueryPhase: image

elasticsearchmachine commented 1 year ago

Pinging @elastic/es-perf (Team:Performance)