search

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
69.98k stars 24.75k forks source link

Rethink simulated GC pause disruption tests #94206

Open rjernst opened 1 year ago

rjernst commented 1 year ago

The disruption tests try to simulate various pauses that could occur within ES. One of these possible pauses is a GC pause. The disruption tests simulate GC pauses using Thread suspend/resume. However, in JDK 20, Thread suspend/resume now throws UnsupportedOperationException (those methods have been deprecated since JDK 1.2, and are slated for permanent removal).

We should rethink how to simulate GC pauses (perhaps with external jvm control like JVMTI), or more broadly whether the disruption tests still provide value (they are complicated and have been flaky in the past).

elasticsearchmachine commented 1 year ago

Pinging @elastic/es-distributed (Team:Distributed)

rjernst commented 1 year ago

See https://github.com/elastic/elasticsearch/issues/93707 for original investigation and discussion into jdk20 test failures.