search

elastic / elasticsearch

Free and Open Source, Distributed, RESTful Search Engine
https://www.elastic.co/products/elasticsearch
Other
1.05k stars 24.83k forks source link

Third-party GeoIP tests running incorrectly / failing #99389

Open brianseeders opened 1 year ago

brianseeders commented 1 year ago

While migrating this job to Buildkite, I discovered that the tests are not actually running correctly in Jenkins.

The argument -Dgeoip_use_service=true is not being passed in correctly, so it's not being used. The result is that a fixture is being used when it shouldn't be.

To fix the argument in Jenkins, it can be changed to -Dtests.jvm.argline="-Dgeoip_use_service=true".

I've already changed this in Buildkite, but it causes the tests to start failing once they are executing correctly. I would suggest that whoever sorts out the tests also fixes the argument in Jenkins in the same PR.

Here is the result from the Buildkite build with the flag fixed.

./gradlew :modules:ingest-geoip:internalClusterTest -Dtests.jvm.argline="-Dgeoip_use_service=true" to run them locally.

elasticsearchmachine commented 1 year ago

Pinging @elastic/es-data-management (Team:Data Management)