search

elastic / ember

Elastic Malware Benchmark for Empowering Researchers
Other
954 stars 279 forks source link

Might some code look like incorrect #2

Closed PinGMUICT closed 6 years ago

PinGMUICT commented 6 years ago

In "trainember.py" script at row number 20, ("if not (os.path.exists(X_train_path) and os.path.exists(y_trainpath))"). I thinking this one will be used to check the existing path and files of training dataset. In case, the files are existing then it will return true and create vectorized features.

Might the "not" code in this line be eliminated ?

Please forgive me if I misunderstand about this.

mrphilroth commented 6 years ago

Thanks for your interest in this project! That line simply checks if vectorized features already exist. If they do not exist (hence the "not"), then they need to be calculated. It's an expensive operation and so I don't want to run it if it's already been done.