search

elastic / ember

Elastic Malware Benchmark for Empowering Researchers
Other
948 stars 277 forks source link

Pin lief version #82

Closed danibachar closed 2 years ago

danibachar commented 2 years ago

Since lief version 0.12.0 was released two days ago the ember package was crashing on pip install. Seems like a simple solution could be to just pin a known to work version

cla-checker-service[bot] commented 2 years ago

💚 CLA has been signed

danibachar commented 2 years ago

I have signed the agreement

mrphilroth commented 2 years ago

This is a good idea, as LIEF versioning is leading to more and more installation issues. But I want to pin to version 0.9.0 that EMBER version 2 features were generated with. I created a PR with those changes: https://github.com/elastic/ember/pull/90

jessdaubner commented 2 years ago

Closed in favor of https://github.com/elastic/ember/pull/90