elastic / ember

Elastic Malware Benchmark for Empowering Researchers
Other
948 stars 277 forks source link

Update ember for lief 0.12.1 #89

Closed PFGimenez closed 2 years ago

PFGimenez commented 2 years ago

Due to a change of API in lief 0.12.1, the following line in features.py: entry_section = lief_binary.section_from_offset(lief_binary.entrypoint).name is crashing as "section_from_offset" now returns None.

This commit makes features.py use the new API (I got it from lief’s main dev). The change is backward compatible: I tested the code with lief 0.11.0 without any issue.

I am not sure ember is entirely compatible with lief 0.12.1 now: I just know that my use case works now. You might want to run additional tests before calling ember compatible with lief 0.12.1.

cla-checker-service[bot] commented 2 years ago

💚 CLA has been signed

PFGimenez commented 2 years ago

I signed the agreement

mrphilroth commented 2 years ago

This looks good. I'm working on getting write access to the repo so that I can merge. Thanks for the contribution.