chore: clean-up work - Githubissues

elastic / enterprise-search-js

Official Node.js client for Elastic Enterprise Search, App Search, and Workplace Search.

Apache License 2.0

2 stars 10 forks source link

Closed TattdCodeMonkey closed 1 year ago

TattdCodeMonkey commented 1 year ago

Updated the node matrix for CI to use v18 instead of v17 of node. v18 is now LTS and odd versions are not recommended.
Updated the universal client unit tests to conditionally import AbortController only when using node v14. It is included in node v16 and I was seeing test failures on macOS and linux when using node v16.

TattdCodeMonkey commented 1 year ago

@sethmlarson v14 still has maintenance support until 2023-04-30 so maybe best to keep support for it until it is EOL.

sethmlarson commented 1 year ago

Sounds good to me, let's merge.