implement base structure

elastic / enterprise-search-network-drive-connector

Official Enterprise Search | Workplace Search - Network Drives Connector

Other

6 stars 3 forks source link

implement base structure #6

Closed praveen-elastic closed 2 years ago

praveen-elastic commented 2 years ago

Things included as a part of the PR:

Makefile Setup.py Base Commands and cli Schema Test connectivity Checkpoint mechanism, Configuration validation (same as SharePoint connector files)

artem-shelkovnikov commented 2 years ago

@praveen-elastic I've approved the PR, but the test coverage is missing. Can you add tests for the code that's present in this PR so that 50% coverage is fulfilled?

nirav-elastic commented 2 years ago

Left minor comments, overall a good direction with tests!

@artem-shelkovnikov , We've addressed all of your comments and the CI is passing as well. Let us know if this is good to merge now.