search

elastic / eui

Elastic UI Framework 🙌
https://eui.elastic.co/
Other
52 stars 841 forks source link

[EuiCodeEditor] Wrongly implies it is edit-able #2210

Closed walterra closed 3 years ago

walterra commented 5 years ago

This can be reproduced on the EUI example page in the read-only example: https://elastic.github.io/eui/#/forms/code-editor

Steps to reproduce:

  1. Put cursor in editor textarea
  2. Hit ESC
  3. An overlay shows up and says: Press Enter to start interacting with the code. When you're done, press Escape to stop interacting with the code.. Note on Kibana master we get: Press Enter to start editing. When you're done, press Escape to stop editing.

Suggested solution: The ESC key should not trigger the overlay in read-only mode.

image

Related Kibana/ML issue: https://github.com/elastic/kibana/issues/41832

anishagg17 commented 4 years ago

@walterra I can't reproduce this issue

myasonik commented 4 years ago

Reproduced on the EUI docs in FF. Also found a related issue in that the same overlay comes up when tabbing into the code editor.

@anishagg17 You'll also note that we've got a design decision label added to this PR which means we don't have a plan on how to solve the current issue. Do you have a suggestion? We should probably have a plan before jumping into code.

If you want to work on EuiCodeEditor, there are still the two issues you picked up earlier briefly that still require work: https://github.com/elastic/eui/issues/2960, https://github.com/elastic/eui/issues/2961

readonly

anishagg17 commented 4 years ago

@myasonik

If you want to work on EuiCodeEditor, there are still the two issues you picked up earlier briefly that still require work: #2960, #2961

these two issues are by the side of react-ace

one has been fixed in their update and other still needs to be fixed by them

thompsongl commented 3 years ago

Closing. EuiCodeEditor has been deprecated and will soon be removed from EUI. See #3807 for recommended options.