search

elastic / eui

Elastic UI Framework 🙌
https://eui.elastic.co/
Other
6.09k stars 838 forks source link

[EuiBasicTable] When switching pages, the selected content in the list needs to be recorded #6308

Closed 1a57danc3 closed 1 year ago

1a57danc3 commented 2 years ago

https://elastic.github.io/eui/#/tabular-content/tables#adding-selection-to-a-table

When switching pages, the selected content in the list needs to be recorded

miukimiu commented 2 years ago

Thanks, @0ne1astk155 for opening this issue.

Unfortunately, our table examples really need better code examples. Those examples are very old and don't even open in CodeSandbox. Also, they contain some issues like the one you mentioned. When switching pagination the selection doesn't get recorded.

We have a goal to improve the tables examples:

I think we can use Faker to create better examples. So this will make sure the examples open in CodeSandbox. Also, we need to make sure the examples work as expected:

cee-chen commented 1 year ago

@miukimiu is this resolved as of #6521?

cee-chen commented 1 year ago

Closing this in favor of https://github.com/elastic/eui/issues/4090. It sounds like the issue of EuiInMemoryTable saving row selection state between pages is something that EUI determined to be too difficult UX wise for us to determine OOTB - consumers should instead manage this themselves with the setSelection API (available through the table ref) if they require this functionality.