elastic / eui

Elastic UI Framework 🙌
https://eui.elastic.co/
Other
53 stars 841 forks source link

[EuiDataGrid] Sort fields panel shows long names centralised on Safari #7551

Open machadoum opened 8 months ago

machadoum commented 8 months ago

Describe the bug When displayAsText is long and the panel has a scroll bar (only on Safari), the field name is horizontally centralised.

Impact and severity Very Low

Environment and versions

To Reproduce Steps to reproduce the behavior:

  1. Go to https://zndqlz.csb.app
  2. Click on 'Sort fields'
  3. Click on 'Pick fields to sort by'
  4. See error

Expected behavior The field name should be displayed in a single line, like on Chrome.

Minimum reproducible sandbox https://codesandbox.io/p/sandbox/restless-browser-zndqlz

Screenshots

Safari

Screenshot 2024-03-05 at 15 39 34

Chrome

Screenshot 2024-03-05 at 15 54 55

Additional context This bug was found during Kibana QA testing: https://github.com/elastic/kibana/issues/177873

cee-chen commented 8 months ago

This is a strange CSS bug caused by the browser scrollbar that can't be easily fixed without downsides. I spiked it out in #7567 but ended mildly disliking the visual tradeoff it caused in popovers that did not have scrollbars.

IMO, we should opt for redesigning this popover wholly (see Caroline's UI suggestion in https://github.com/elastic/eui/issues/5894#issuecomment-1124031122) and resolving it that way.

If we don't end up implementing the new design, we could resurrect my PR in a pinch if absolutely needed, but since this is low priority/severity, I'm not sure we need to.