Open tkajtoch opened 3 weeks ago
I'm generally not a huge fan of adding functionality to production components for the sake of non-production use-cases. Can I ask why we can't just disable EUI's global styles completely via <EuiProvider globalStyles={false} />
and then just manually import or copy/paste the styles we do want to Docusaurus? That would personally by my preference (putting logic/customization in the lower stakes repo).
The idea was to be able to reuse some of the things where needed by making this more flexible. But I can agree that:
I think we could work also with globalStyles={false}
for now and see later in the process how useful the granular update of EuiGlobalStyles
will be and decide then if we want to move forward with this? cc @tkajtoch
The second bullet point is definitely my concern! I think I just also don't want to spend too much time reviewing/working on future-proof logic on source code when we don't have clear production usages in mind. Hope that makes sense!
Summary
EuiProvider
's default global styles are overriding and breaking some docusaurus styles, making its typography unusable. We need to find a way how to balance these two either by fixingEuiProvider
to allow disabling some of its global styles or making docusaurus styles specificity higherAcceptance criteria
EuiProvider
is used