search

elastic / eui

Elastic UI Framework 🙌
https://eui.elastic.co/
Other
6.08k stars 826 forks source link

Data grid checkboxes are misaligned with row height #7897

Open lukasolson opened 1 month ago

lukasolson commented 1 month ago

Describe the bug

See https://eui.elastic.co/#/tabular-content/data-grid-schema-columns#control-columns. When you switch the data grid row height to "Auto fit" or "Custom", the check boxes are no longer properly vertically aligned.

Screenshots

https://github.com/user-attachments/assets/bf5433f6-0453-4b61-95e7-9adc041bba53

cee-chen commented 1 month ago

When you switch the data grid row height to "Auto fit"

This one is working as intended, auto fit row heights do not vertically center their content as the row height can be any height and the checkboxes should be top-aligned instead of middle-aligned.

For "Custom" heights of 1 line, this should be resolved in the future by adopting Davis's suggestion here: https://github.com/elastic/eui/issues/7780#issuecomment-2183481704

For custom heights of more than 1 line, again, checkboxes should be top-aligned instead of middle-aligned so that is working as expected.

github-actions[bot] commented 1 month ago

👋 Thank you for your suggestion or request! While the EUI team agrees that it's valid, it's unlikely that we will prioritize this issue on our roadmap. We'll leave the issue open if you or anyone else in the community wants to implement it by contributing to EUI. If not, this issue will auto close in one year.

Log | Bot Usage