elastic / eui

Elastic UI Framework 🙌
https://eui.elastic.co/
Other
54 stars 841 forks source link

[EuiDataGrid] Vertically center toolbar `additionalControls` items #8085

Closed janmonschke closed 1 month ago

janmonschke commented 1 month ago

Summary

I recently noticed that the alerts table toolbar in security has items that were not vertically centered. I created fixes for that in Kibana but I think the actual fix would be to add align-items: center; to the actual wrapper classes, hence this PR. [Kibana PR]

Alerts table before:

Screenshot 2024-10-18 at 09 47 53

Alerts table after:

Screenshot 2024-10-18 at 09 47 14

TODO:

cee-chen commented 1 month ago

I think my only hesitation is this might affect other data grids in Kibana that have custom toolbar items that prefer top alignment - I'm not sure what those cases might be, but I'm also don't have every Kibana datagrid memorized 😅 I took a quick peek at Discover and Lens and those look like they should be fine, so I'm good with moving forward with this, but we should add a changelog for this to surface it to consumers just in case. I'll add one here shortly

kibanamachine commented 1 month ago

Preview staging links for this PR:

elasticmachine commented 1 month ago

:green_heart: Build Succeeded

History

janmonschke commented 1 month ago

@cee-chen thanks for adding the changelog and reviewing this PR so swiftly :)

janmonschke commented 1 month ago

@cee-chen Is there an epic or sth similar that I could follow to get notified about the next EUI release?

cee-chen commented 1 month ago

No epic, but generally EUI changes will reach Kibana in 1-2 weeks. You can peek at the EUI tag in Kibana. We're going to do another release for the currently in-draft PR so it's likely this change will reach Kibana by end of next Friday.