search

elastic / eui

Elastic UI Framework 🙌
https://eui.elastic.co/
Other
54 stars 841 forks source link

fix(docusaurus-theme): fill Codesandbox icon with currentColor #8127

Closed weronikaolejniczak closed 1 week ago

weronikaolejniczak commented 2 weeks ago

Summary

The Codesandbox icon in the footer of each example in EUI+ doesn't change the color depending on the theme (dark / light mode).

QA

  1. Open the new docs.
  2. Navigate to any component page (e.g. Accordion).
  3. Notice the component preview. In the footer, there's a Codesandbox icon.
  4. Switch themes using the toggle in the top right of the page.
  5. Verify that the Codesandbox icon is visible. In light mode it should be black, in dark mode white.

https://github.com/user-attachments/assets/989811da-3fcd-4384-9bc1-d810cea331ca

mgadewoll commented 1 week ago

@weronikaolejniczak

Nothing is applicable... 👀

A general fyi for the "QA" section: We have the general QA checklist but besides that you can add your own QA instructions. E.g. something like this:

- open EUI+ docs (example link here)
- toggle the color mode switch in the page header
- [ ] verify that the codesandbox icon on code examples updates its color accordingly on color mode change

There is no expected pattern for this, just in general some instructions to follow for people to know what to look at and verify considering someone might see it and not fully know what it's about (this PR is simple but more as a common approach)

weronikaolejniczak commented 1 week ago

@mgadewoll that's a good point 👌🏻 I updated the description with proper QA instructions.

kibanamachine commented 1 week ago

Preview staging links for this PR:

elasticmachine commented 1 week ago

:green_heart: Build Succeeded

History