[Visual Refresh] Fix euiColorFullShade Sass variable mapping

elastic / eui

Elastic UI Framework 🙌

https://eui.elastic.co/

Other

54 stars 841 forks source link

[Visual Refresh] Fix euiColorFullShade Sass variable mapping #8178

Closed mgadewoll closed 5 hours ago

mgadewoll commented 5 hours ago

Summary

[!NOTE] This PR merges into a feature branch.

This PR fixes a wrong Sass variable mapping. euiColorFullShade in light color mode should be mapped to euiColorPlainDark as it's the darkest (legacy) shade. It having been mapped to euiColorPlainLight (which is white) was a mistake, likely due to copying.

QA

There is no actual output of this in EUI. The EUI docs here use the legacy JSON tokens as output.

kibanamachine commented 5 hours ago

Preview staging links for this PR:

Docs site: https://eui.elastic.co/pr_8178/
Storybook: https://eui.elastic.co/pr_8178/storybook
New docs: https://eui.elastic.co/pr_8178/new-docs

elasticmachine commented 5 hours ago

:green_heart: Build Succeeded

Buildkite Build
Commit: dee3714658d763311c53dbc7ef20587cc45b7169