search

elastic / go-elasticsearch

The official Go client for Elasticsearch
https://github.com/elastic/go-elasticsearch#go-elasticsearch
Apache License 2.0
5.65k stars 612 forks source link

[Testcontainers] move integration test to internal #855

Closed Anaethelion closed 4 months ago

Anaethelion commented 4 months ago

Follow up PR to #824

This moves over the integration test into an internal package to avoid importing testcontainers-go and dependencies into the main library.

mdelapenya commented 4 months ago

Thanks for this! I like the approach of creating a new module for the ITs, so that the indirect deps are not pushed to clients. I did exactly the same for the compose module for testcontainers-go, to avoid. pushing all compose deps to all users.

Cheers!