elastic / go-sysinfo

go-sysinfo is a library for collecting system information.
Apache License 2.0
356 stars 87 forks source link

Add Domain to types.Host #212

Open andrewkroh opened 5 months ago

andrewkroh commented 5 months ago

Add a Domain Field to the types.Host struct. For Windows this should be populated with the host's Active Directory (AD) or Entra ID domain name. This value should satisfy the definition of the host.domain field in ECS.

Windows registry data sources

References

jrmolin commented 5 months ago

Is that Iff an If-and-only-if or just a mistype? From context, it looks like if-and-only-if. I love seeing the maths in here!

andrewkroh commented 5 months ago

That's the problem with iff outside of math/logic contexts, you never know if it is intentional or a typo 😆 . I did lazily mean if and only if. I probably should have written "if JoinInfo contains exactly one subkey then read the UserEmail value from that subkey...".