search

elastic / golang-crossbuild

Apache License 2.0
5 stars 32 forks source link

[golang-crossbuild] Can CI skip running when non-code related changes? #457

Open v1v opened 2 months ago

v1v commented 2 months ago

https://github.com/elastic/golang-crossbuild/pull/450 or https://github.com/elastic/golang-crossbuild/pull/452 are changes that are not tested by the CI

@elastic/ingest-eng-prod , can the CI Buildkite pipelines be configured to run smartly what needs to be done?

rowlandgeoff commented 1 month ago

I've done a couple test PRs and CI is still running. Will need to keep investigating.

rowlandgeoff commented 1 month ago

I've compared the settings to the instructions at https://docs.elastic.dev/ci/configuring-pull-requests-for-buildkite and the settings in elastic-agent, where I know I've seen this functionality work. Still not sure what's going wrong.

I've set the golang-crossbuild required status check to any source in the branch protection rules, which I had to do in the elastic-agent repo a little while ago.

One of the test PRs: https://github.com/elastic/golang-crossbuild/pull/475

I will also need to make the json change for the other two pipelines in pull-requests.json, since they run on PRs. But going to wait until I understand why golang-crossbuild is still running.