search

elastic / gsoc

Google Summer of Code at Elastic: Projects and guidelines
44 stars 12 forks source link

Update elasticsearch-lua #4

Closed t2013anurag closed 6 years ago

t2013anurag commented 6 years ago

I would love to update and add the missing functionalities in the Lua.

@logmonster @aravindputrevu Can we connect and discuss further?

pmusa commented 6 years ago

Hy @t2013anurag, happy to see your interest and to discuss further. Are you already using elasticsearch-lua? Do you have any questions?

t2013anurag commented 6 years ago

@pmusa - I came across elasticsearch-lua and the documentation

Quick question - Is this the repository, we need to work on? What all features need to be written in Lua script? Can you refer me to the documentation or the right repo, if the above one is wrong?

pmusa commented 6 years ago

Is this the repository, we need to work on?

Yes, this is the original repo. But you could work on a fork, if you prefer.

What all features need to be written in Lua script?

Yes, they need. You write a few of them in C, but I am not that is worth it.

t2013anurag commented 6 years ago

@pmusa - Thanks, Can you give an example of any such feature which needs to be implemented? This would allow me to familiarize with the codebase real quick. I will fork the repo and implement on it.

SatyendraBanjare commented 6 years ago

Hello @pmusa.... I have successfully Setup ElasticSearch-lua in my system and successfully tested it over elastic 2.4 and it is working just as expected. I when trying with elastic 6.2 it's giving index call errors as explained by Dhaval Kapil here at link. Please tell me on how to proceed further.... :smile:

pmusa commented 6 years ago

Sorry @t2013anurag for late response, but we had Elastic{ON} and then team meeting, so I was away for a while. The client update is not only about new features, but about updating what is broken. @SatyendraBanjare had a good example that even indexing a document was not working because starting in ES 5.x you need to provide the content-type in the header. This is one of the examples and you can find many more by looking into the breaking changes from 5.0 until 6.2.

pmusa commented 6 years ago

how to proceed further....

My expectation is to have students look into the breaking changes and understand what has changed since 2.x. Based on that, define potential changes and a timeline to execute them, as recommended in our main page. As stated in the ideas page, we expect a student to have intermediate knowledge about Lua, Elasticsearch, JSON, and HTTP. So, I recommend you show that by creating a pull request.

xeraa commented 6 years ago

Closing since the application period has finished. We can start a new discussion as needed.