search

elastic / helm-charts

You know, for Kubernetes
Apache License 2.0
1.88k stars 1.93k forks source link

Logstash template for ServiceAccount has annotations, twice #1718

Open woutersmit opened 1 year ago

woutersmit commented 1 year ago

Chart version: logstash 7.17.3

Kubernetes version: does not apply

Kubernetes provider: E.g. GKE (Google Kubernetes Engine) does not apply

Helm Version: 3.9.0

helm get release output

Output of helm get release ``` apiVersion: v1 kind: ServiceAccount metadata: name: "salvador-logstash" annotations: labels: app: "salvador-logstash" chart: "logstash" heritage: "Helm" release: "salvador" annotations: annotation1: "value1" ```

Describe the bug: The logstash template for ServiceAccount has annotations twice. You can workaround this by leaving either .Values.rbac.serviceAccountAnnotations or .Values.rbac.annotations empty, but this is only because kubeapi is forgiving. Invalid yaml is being generated.

Steps to reproduce:

  1. Any basic release that has rbac: create: true

Expected behavior: Valid yaml is being generated.

botelastic[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.