agent/tracer cleanup - Githubissues

elastic / hey-apm

Basic load generation for apm-server built on hey

Apache License 2.0

16 stars 16 forks source link

agent/tracer cleanup #184

Closed axw closed 4 years ago

axw commented 4 years ago

In agent.Tracer:

remove the separate goroutine used for measuring request/response stats and recording errors; do this in the RoundTripper wrapper itself.
- decode server responses into struct to minimise use of reflection, simplifying code and increasing type safety; remove subsequently unused conv.As* methods.
- use a map to track unique errors rather than strcoll.Contains, which has now been removed.

Move agent.Tracer to the worker package, unexporting the type (worker.tracer).

apmmachine commented 4 years ago

:green_heart: Build Succeeded

Expand to view the summary

#### Build stats * Build Cause: `[Pull request #184 opened]` * Start Time: 2020-07-30T06:50:03.284+0000 * Duration: 3 min 24 sec #### Test stats :test_tube: | Test | Results | | ------------ | :-----------------------------: | | Failed | 0 | | Passed | 9 | | Skipped | 0 | | Total | 9 |